Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint no-default-exports 11 - icons (last one for desktop-client package) #2173

Merged

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 4, 2024

The number of files changed should go down once the previous parts gets merged.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 03e48b4
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6599bee7127f810008fa56bc
😎 Deploy Preview https://deploy-preview-2173.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the title ESLint no-default-exports 11 - icons ESLint no-default-exports 11 - icons (last one for desktop-client package) Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.09 MB → 3.08 MB (-8.86 kB) -0.28%
Changeset (largest 100 files by percent change)
File Δ Size
src/icons/v0/Math.tsx 🆕 +2 kB 0 B → 2 kB
src/icons/v0/index.ts 🆕 +360 B 0 B → 360 B
package.json 📈 +58 B (+2.64%) 2.15 kB → 2.2 kB
src/components/filters/CompactFiltersButton.tsx 📈 +6 B (+1.45%) 414 B → 420 B
src/components/filters/FiltersButton.tsx 📈 +6 B (+0.93%) 645 B → 651 B
src/components/reports/LoadingIndicator.tsx 📈 +4 B (+0.39%) 1015 B → 1019 B
src/components/AnimatedRefresh.tsx 📈 +2 B (+0.28%) 724 B → 726 B
src/components/AppBackground.tsx 📈 +4 B (+0.27%) 1.43 kB → 1.43 kB
src/components/util/LoadComponent.tsx 📈 +4 B (+0.23%) 1.67 kB → 1.68 kB
src/components/sidebar/Accounts.tsx 📈 +6 B (+0.13%) 4.62 kB → 4.63 kB
src/components/modals/Notes.tsx 📈 +4 B (+0.12%) 3.22 kB → 3.23 kB
src/components/Notifications.tsx 📈 +7 B (+0.08%) 8.48 kB → 8.48 kB
src/components/UpdateNotification.tsx 📈 +4 B (+0.08%) 4.97 kB → 4.97 kB
src/components/modals/PlaidExternalMsg.tsx 📈 +4 B (+0.07%) 5.67 kB → 5.67 kB
src/components/common/Button.tsx 📈 +4 B (+0.07%) 5.82 kB → 5.82 kB
src/components/accounts/MobileAccounts.jsx 📈 +6 B (+0.06%) 9.58 kB → 9.58 kB
src/components/modals/EditField.jsx 📈 +6 B (+0.06%) 9.79 kB → 9.79 kB
src/components/common/Modal.tsx 📈 +7 B (+0.05%) 12.63 kB → 12.63 kB
src/components/autocomplete/CategoryAutocomplete.tsx 📈 +4 B (+0.04%) 8.86 kB → 8.86 kB
src/components/autocomplete/PayeeAutocomplete.tsx 📈 +6 B (+0.04%) 15.51 kB → 15.52 kB
src/components/budget/MobileBudget.jsx 📈 +4 B (+0.03%) 15.15 kB → 15.16 kB
src/components/autocomplete/Autocomplete.tsx 📈 +3 B (+0.01%) 22.14 kB → 22.14 kB
src/components/filters/SavedFilters.jsx 📉 -2 B (-0.01%) 13.09 kB → 13.09 kB
src/components/payees/ManagePayees.jsx 📉 -2 B (-0.02%) 11.22 kB → 11.22 kB
src/components/budget/rollover/RolloverComponents.tsx 📉 -3 B (-0.02%) 16.42 kB → 16.41 kB
src/components/budget/report/ReportComponents.tsx 📉 -3 B (-0.02%) 15.25 kB → 15.25 kB
src/components/filters/FiltersMenu.jsx 📉 -5 B (-0.02%) 24.35 kB → 24.34 kB
src/components/sidebar/SidebarWithData.tsx 📉 -2 B (-0.03%) 5.98 kB → 5.98 kB
src/components/common/Select.tsx 📉 -2 B (-0.04%) 5.57 kB → 5.56 kB
src/components/budget/SidebarCategory.tsx 📉 -3 B (-0.05%) 6.45 kB → 6.45 kB
src/components/accounts/Reconcile.jsx 📉 -3 B (-0.05%) 6.39 kB → 6.39 kB
src/components/modals/GoCardlessExternalMsg.tsx 📉 -7 B (-0.05%) 13.11 kB → 13.1 kB
src/components/schedules/SchedulesTable.tsx 📉 -7 B (-0.05%) 12.83 kB → 12.83 kB
src/components/budget/SidebarGroup.tsx 📉 -5 B (-0.06%) 7.75 kB → 7.75 kB
src/components/reports/SaveReport.tsx 📉 -2 B (-0.08%) 2.41 kB → 2.41 kB
src/components/sidebar/ToggleButton.tsx 📉 -1 B (-0.09%) 1.13 kB → 1.13 kB
src/components/transactions/SimpleTransactionsTable.jsx 📉 -8 B (-0.09%) 8.78 kB → 8.77 kB
src/components/table.tsx 📉 -33 B (-0.10%) 32.53 kB → 32.5 kB
src/components/accounts/Balance.jsx 📉 -8 B (-0.12%) 6.72 kB → 6.71 kB
src/components/payees/PayeeTableRow.tsx 📉 -5 B (-0.12%) 4.15 kB → 4.14 kB
src/components/modals/EditRule.jsx 📉 -51 B (-0.14%) 36.57 kB → 36.52 kB
src/components/accounts/AccountSyncCheck.jsx 📉 -9 B (-0.15%) 5.72 kB → 5.71 kB
src/components/budget/MobileBudgetTable.jsx 📉 -86 B (-0.16%) 52.94 kB → 52.85 kB
src/components/select/RecurringSchedulePicker.jsx 📉 -42 B (-0.18%) 22.6 kB → 22.56 kB
src/components/MobileBackButton.tsx 📉 -3 B (-0.22%) 1.36 kB → 1.36 kB
src/components/NotesButton.tsx 📉 -7 B (-0.22%) 3.12 kB → 3.12 kB
src/components/transactions/MobileTransaction.jsx 📉 -123 B (-0.22%) 54.52 kB → 54.4 kB
src/components/budget/BudgetTotals.tsx 📉 -11 B (-0.23%) 4.73 kB → 4.72 kB
src/components/budget/BalanceWithCarryover.tsx 📉 -5 B (-0.23%) 2.08 kB → 2.07 kB
src/components/transactions/TransactionsTable.jsx 📉 -185 B (-0.27%) 67.66 kB → 67.47 kB
src/components/reports/CategorySelector.tsx 📉 -52 B (-0.46%) 11.08 kB → 11.03 kB
src/components/budget/MonthCountSelector.tsx 📉 -7 B (-0.47%) 1.45 kB → 1.44 kB
src/components/accounts/Header.jsx 📉 -105 B (-0.54%) 18.96 kB → 18.86 kB
src/components/budget/rollover/budgetsummary/BudgetSummary.tsx 📉 -62 B (-0.54%) 11.19 kB → 11.13 kB
src/components/util/AmountInput.tsx 📉 -26 B (-0.55%) 4.59 kB → 4.57 kB
src/components/Titlebar.tsx 📉 -94 B (-0.57%) 16.04 kB → 15.95 kB
src/components/budget/report/budgetsummary/BudgetSummary.tsx 📉 -62 B (-0.58%) 10.35 kB → 10.29 kB
src/components/sidebar/Sidebar.tsx 📉 -35 B (-0.75%) 4.57 kB → 4.53 kB
src/icons/Loading.tsx 📉 -20 B (-0.95%) 2.06 kB → 2.04 kB
src/components/modals/CategoryMenu.tsx 📉 -88 B (-1.19%) 7.23 kB → 7.15 kB
src/icons/v2/MoonStars.tsx 📉 -22 B (-1.25%) 1.71 kB → 1.69 kB
src/components/payees/PayeeMenu.tsx 📉 -26 B (-1.26%) 2.02 kB → 2 kB
src/icons/v1/PiggyBank.tsx 📉 -22 B (-1.28%) 1.68 kB → 1.66 kB
src/components/modals/CategoryGroupMenu.tsx 📉 -115 B (-1.28%) 8.75 kB → 8.64 kB
src/icons/v2/Sun.tsx 📉 -16 B (-1.35%) 1.16 kB → 1.14 kB
src/components/manager/BudgetList.jsx 📉 -162 B (-1.37%) 11.52 kB → 11.36 kB
src/icons/v1/CloudCheck.tsx 📉 -23 B (-1.48%) 1.52 kB → 1.49 kB
src/icons/v2/Hyperlink2.tsx 📉 -23 B (-1.51%) 1.48 kB → 1.46 kB
src/icons/v1/CloudWarning.tsx 📉 -25 B (-1.58%) 1.54 kB → 1.52 kB
src/icons/v2/Calendar3.tsx 📉 -22 B (-1.62%) 1.32 kB → 1.3 kB
src/icons/v1/MoneyBag.tsx 📉 -21 B (-1.66%) 1.24 kB → 1.22 kB
src/icons/v2/CloudUnknown.tsx 📉 -25 B (-1.66%) 1.47 kB → 1.44 kB
src/icons/v2/CloudUpload.tsx 📉 -24 B (-1.74%) 1.35 kB → 1.32 kB
src/icons/v1/PencilWrite.tsx 📉 -24 B (-1.80%) 1.3 kB → 1.28 kB
src/icons/v1/CloudDownload.tsx 📉 -26 B (-1.83%) 1.39 kB → 1.36 kB
src/icons/v2/Hyperlink3.tsx 📉 -23 B (-1.84%) 1.22 kB → 1.2 kB
src/icons/v1/Bug.tsx 📉 -16 B (-1.84%) 871 B → 855 B
src/components/alerts.tsx 📉 -45 B (-1.88%) 2.33 kB → 2.29 kB
src/icons/v1/Add.tsx 📉 -16 B (-1.89%) 847 B → 831 B
src/icons/v1/Cog.tsx 📉 -16 B (-1.89%) 846 B → 830 B
src/icons/v1/Network.tsx 📉 -20 B (-1.92%) 1.02 kB → 1022 B
src/components/common/Search.tsx 📉 -42 B (-1.97%) 2.08 kB → 2.04 kB
src/icons/AnimatedLoading.tsx 📉 -15 B (-1.97%) 760 B → 745 B
src/icons/v1/Buoy.tsx 📉 -17 B (-1.97%) 861 B → 844 B
src/components/common/MenuButton.tsx 📉 -11 B (-2.00%) 551 B → 540 B
src/icons/v0/Add.tsx 📉 -16 B (-2.06%) 777 B → 761 B
src/icons/v2/NotesPaperText.tsx 📉 -27 B (-2.13%) 1.24 kB → 1.21 kB
src/icons/v2/Key.tsx 📉 -16 B (-2.17%) 738 B → 722 B
src/icons/v1/FileDouble.tsx 📉 -23 B (-2.21%) 1.02 kB → 1020 B
src/components/mobile/MobileNavTabs.tsx 📉 -147 B (-2.27%) 6.31 kB → 6.17 kB
src/icons/v2/Pencil1.tsx 📉 -20 B (-2.29%) 874 B → 854 B
src/icons/v2/NavigationMenu.tsx 📉 -27 B (-2.37%) 1.11 kB → 1.08 kB
src/icons/v1/Link.tsx 📉 -17 B (-2.45%) 693 B → 676 B
src/components/ThemeSelector.tsx 📉 -48 B (-2.47%) 1.9 kB → 1.85 kB
src/icons/v2/RemoveAlternate.tsx 📉 -28 B (-2.51%) 1.09 kB → 1.06 kB
src/icons/v2/Calendar.tsx 📉 -21 B (-2.51%) 836 B → 815 B
src/icons/v1/Chart.tsx 📉 -18 B (-2.51%) 716 B → 698 B
src/icons/v1/DialPad.tsx 📉 -20 B (-2.53%) 791 B → 771 B
src/icons/v1/Radio.tsx 📉 -18 B (-2.54%) 710 B → 692 B
src/icons/v2/ArrowsSynchronize.tsx 📉 -30 B (-2.56%) 1.15 kB → 1.12 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.43 MB → 1.43 MB (+7.45 kB) +0.51%

Smaller

Asset File Size % Changed
static/js/553.chunk.js 28.56 kB → 13.14 kB (-15.42 kB) -54.00%
static/js/wide-components.chunk.js 112.99 kB → 112.25 kB (-752 B) -0.65%
static/js/reports.chunk.js 77.93 kB → 77.81 kB (-125 B) -0.16%
static/js/narrow-components.chunk.js 45.18 kB → 45.15 kB (-35 B) -0.08%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@joel-jeremy joel-jeremy force-pushed the eslint-no-default-exports-11 branch 4 times, most recently from ee6a1cd to 03e48b4 Compare January 6, 2024 20:58
@joel-jeremy joel-jeremy merged commit 30bc216 into actualbudget:master Jan 6, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 6, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
… package) (actualbudget#2173)

* ESLint no-default-exports 10 - icons

* Fix icon imports + lint errors

* Release notes

* Fix typecheck error

* Fix icon import

* Fix lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants